Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Commits made with gert are not gpg signed #186

Open
czeildi opened this issue Sep 17, 2022 · 1 comment
Open

Commits made with gert are not gpg signed #186

czeildi opened this issue Sep 17, 2022 · 1 comment

Comments

@czeildi
Copy link

czeildi commented Sep 17, 2022

I have gpg signing set up for every commit, i.e. commit.gpgsign is true and if I commit from the command line, all my commits are indeed gpg signed.

If I commit with gert::git_commit, my commits are not signed.

I would expect them to be signed, or show a warning that the commits are not signed.

Or if this is out of scope, maybe a note could be added to the documentation.

I am not sure how to set up a proper reprex, but here is a sandbox repository where I experimented: https://github.com/czeildi/gert-sandbox/commits/main

@czeildi
Copy link
Author

czeildi commented Sep 17, 2022

for context: originally I burned myself using usethis::pr_merge_main on a repository that requires all commits to be signed for merging a PR and tracked that gert is used under the hood.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant