Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Global option to disable unicode in condition bullets #396

Closed
lionel- opened this issue Jan 19, 2022 · 1 comment · Fixed by #411
Closed

Global option to disable unicode in condition bullets #396

lionel- opened this issue Jan 19, 2022 · 1 comment · Fixed by #411
Labels
feature a feature request or enhancement
Milestone

Comments

@lionel-
Copy link
Member

lionel- commented Jan 19, 2022

This option should only be inspected when cli.unicode is enabled. I.e. it's a way of opting out of unicode in condition message bullets when unicode is globally enabled, not opting in when it's globally disabled.

This way reproducible environments only need to disable cli.unicode without having to know about condition bullets. On the other hand, unit tests that specifically enable unicode will need to know about the bullets-specific option for reproducibility in sessions where the user has disabled unicode bullets, but that's a rare case.

I think the name should be nested in cli.unicode_, mention bullets, and mention that it's about condition messaging. One of these would be good:

  • cli.unicode_cnd_bullets
  • cli.unicode_condition_bullets
  • cli.unicode_message_bullets

Or perhaps nest in cli.unicode_bullets_ in case similar options are added for bullets in other contexts?

@lionel- lionel- added this to the 3.2.0 milestone Jan 19, 2022
@gaborcsardi
Copy link
Member

cli.condition_unicode_bullets it will be

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature a feature request or enhancement
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants