Make some snapshot tests more robust

r-hub · Apr 8, 2024 · 1db6a87 · 1db6a87
1 parent e1e9a0f
commit 1db6a87
Show file tree

Hide file tree

Showing 3 changed files with 12 additions and 4 deletions.
diff --git a/tests/testthat/_snaps/api.md b/tests/testthat/_snaps/api.md
@@ -7,7 +7,7 @@
         "args": {},
         "headers": {
           "Host": "127.0.0.1:<port>",
-          "Accept-Encoding": "deflate, gzip",
+          "Accept-Encoding": "<encodings>",
           "accept": "application/json",
           "content-type": "application/json",
           "user-agent": "R-hub client"
@@ -55,7 +55,7 @@
         "form": {},
         "headers": {
           "Host": "127.0.0.1:<port>",
-          "Accept-Encoding": "deflate, gzip",
+          "Accept-Encoding": "<encodings>",
           "accept": "application/json",
           "content-type": "application/json",
           "user-agent": "R-hub client",

diff --git a/tests/testthat/helpers.R b/tests/testthat/helpers.R
@@ -102,3 +102,11 @@ http <- webfakes::new_app_process(http_app())
 redact_port <- function(x) {
   gsub(":[0-9]+", ":<port>", x)
 }
+
+redact_ae_header <- function(x) {
+  gsub(
+    "\"Accept[-]Encoding\": \"[^\"]*\"",
+    "\"Accept-Encoding\": \"<encodings>\"",
+    x
+  )
+}
diff --git a/tests/testthat/test-api.R b/tests/testthat/test-api.R
@@ -2,7 +2,7 @@ test_that("query GET", {
   withr::local_envvar(RHUB_SERVER = http$url())
   expect_snapshot({
     cat(rawToChar(query("/get")$content))
-  }, transform = redact_port)
+  }, transform = function(x) redact_port(redact_ae_header(x)))
 })
 
 test_that("query HTTP errors", {
@@ -23,7 +23,7 @@ test_that("query POST", {
   data <- charToRaw(jsonlite::toJSON(list(foo = "bar", foobar = 1:3)))
   expect_snapshot({
     cat(rawToChar(query("/post", method = "POST", data = data)$content))
-  }, transform = redact_port)
+  }, transform = function(x) redact_port(redact_ae_header(x)))
 })
 
 test_that("query, unknown verb", {