Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

column_info test inconsistent with spec #109

Closed
imanuelcostigan opened this issue Dec 24, 2016 · 2 comments
Closed

column_info test inconsistent with spec #109

imanuelcostigan opened this issue Dec 24, 2016 · 2 comments

Comments

@imanuelcostigan
Copy link
Contributor

DBI::dbColumnInfo help:

Value: A data.frame with one row per output field in res. Methods MUST include name, field.type (the SQL type), and data.type (the R data type) columns, and MAY contain other database specific information like scale and precision or whether the field can store NULLs.

This means the number of columns of the resulting col info data frame does not have to be two, whereas, in DBItest:

 ci <- dbColumnInfo(res)
expect_identical(colnames(ci), c("name", "type"))

And also, the name of the type field is assumed to be type rather than field.type per doc:

 expect_is(ci$type, "character")

Let me know if I have interpreted this correctly and if you would like me to either submit a PR:

  1. To change the DBI spec
  2. Correct the DBItest cases
@krlmlr
Copy link
Member

krlmlr commented Jan 30, 2017

Thanks. I'll be fixing dbColumnInfo() specs soon, will take care of it. Would you like to comment on r-dbi/DBI#75?

@krlmlr
Copy link
Member

krlmlr commented Apr 5, 2017

Closing in favor of r-dbi/DBI#75.

@krlmlr krlmlr closed this as completed Apr 5, 2017
@github-actions github-actions bot locked and limited conversation to collaborators Dec 5, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants