Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize all results website alt images hosted on imgur #97

Open
JoseiToAoiTori opened this issue Apr 14, 2020 · 0 comments
Open

Optimize all results website alt images hosted on imgur #97

JoseiToAoiTori opened this issue Apr 14, 2020 · 0 comments
Labels
luxury Issue is a lot of work but not integral in any way

Comments

@JoseiToAoiTori
Copy link
Collaborator

Some images take a while to load on slow connections with most of the culprits being unoptimized PNGs. PNGGauntlet can be used to reduce the size of these images without losing quality. Larger resolutions can also be made smaller, converted to JPEG and then optimized via this tool.

The symmetry of the image also raises some issues. On desktop modals, images need to be horizontally centered which is fairly easy to do and most anilist images are horizontally centered by default with the ones we picked also being horizontally centered. Most of them aren't vertically centered though and that causes issues on mobile view where the image ratio is entirely different. This can be fixed by just picking widescreen images that are both horizontally and vertically centered but that's easier said than done.

This issue is a luxury that we should only work on when we don't have a large backlog of critical issues to fix.

@JoseiToAoiTori JoseiToAoiTori added the luxury Issue is a lot of work but not integral in any way label Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
luxury Issue is a lot of work but not integral in any way
Projects
None yet
Development

No branches or pull requests

1 participant