Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split imported events into multiple files. #277

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Split imported events into multiple files.

76a9f4e
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Open

Split imported events into multiple files. #277

Split imported events into multiple files.
76a9f4e
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded May 25, 2024 in 0s

clippy

10 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 10
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 126 in src/importers/webfeet/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `Clone::clone()` may be inefficient

warning: assigning the result of `Clone::clone()` may be inefficient
   --> src/importers/webfeet/mod.rs:126:13
    |
126 |             name = event.value.clone();
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_from()`: `name.clone_from(&event.value)`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check warning on line 69 in src/importers/icalendar/spreefolk.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `ToOwned::to_owned()` may be inefficient

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> src/importers/icalendar/spreefolk.rs:62:13
   |
62 | /             *details = details
63 | |                 .split("\n\n\n\n\n\n\nJavaScript ist in deinem Browser deaktiviert.")
64 | |                 .next()
65 | |                 .unwrap()
...  |
68 | |                 .unwrap()
69 | |                 .to_owned();
   | |___________________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
help: use `clone_into()`
   |
62 ~             details
63 +                 .split("\n\n\n\n\n\n\nJavaScript ist in deinem Browser deaktiviert.")
64 +                 .next()
65 +                 .unwrap()
66 ~                 .split("\n \n\n\n\nJavaScript ist in deinem Browser deaktiviert.")
67 +                 .next()
68 ~                 .unwrap().clone_into(details);
   |

Check warning on line 60 in src/importers/icalendar/spreefolk.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `ToOwned::to_owned()` may be inefficient

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> src/importers/icalendar/spreefolk.rs:57:9
   |
57 | /         event.name = event
58 | |             .name
59 | |             .replace("Folk & Tanz am", "Folk & Dance at")
60 | |             .to_owned();
   | |_______________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
help: use `clone_into()`
   |
57 ~         event
58 +             .name
59 ~             .replace("Folk & Tanz am", "Folk & Dance at").clone_into(&mut event.name);
   |

Check warning on line 48 in src/importers/icalendar/ceilidhclub.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `ToOwned::to_owned()` may be inefficient

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> src/importers/icalendar/ceilidhclub.rs:48:13
   |
48 |             country = "UK".to_owned();
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"UK".clone_into(&mut country)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check warning on line 96 in src/importers/icalendar/cdss.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `ToOwned::to_owned()` may be inefficient

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> src/importers/icalendar/cdss.rs:96:13
   |
96 |             country = "UK".to_owned();
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"UK".clone_into(&mut country)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check warning on line 94 in src/importers/icalendar/cdss.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `ToOwned::to_owned()` may be inefficient

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> src/importers/icalendar/cdss.rs:94:13
   |
94 |             country = "USA".to_owned();
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"USA".clone_into(&mut country)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones

Check warning on line 69 in src/importers/icalendar/boulder.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

assigning the result of `ToOwned::to_owned()` may be inefficient

warning: assigning the result of `ToOwned::to_owned()` may be inefficient
  --> src/importers/icalendar/boulder.rs:69:13
   |
69 |             country = "USA".to_owned();
   |             ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `clone_into()`: `"USA".clone_into(&mut country)`
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assigning_clones
   = note: `#[warn(clippy::assigning_clones)]` on by default

Check warning on line 137 in src/importers/icalendar/balfolknl.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> src/importers/icalendar/balfolknl.rs:137:35
    |
137 |         event.name = shorten_name(&raw_name);
    |                                   ^^^^^^^^^ help: change this to: `raw_name`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 217 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

function `write_events_to_files` is never used

warning: function `write_events_to_files` is never used
   --> src/main.rs:217:4
    |
217 | fn write_events_to_files(events: Events) -> Result<(), Report> {
    |    ^^^^^^^^^^^^^^^^^^^^^
    |
    = note: `#[warn(dead_code)]` on by default

Check warning on line 53 in src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused imports: `env`, `process::exit`

warning: unused imports: `env`, `process::exit`
  --> src/main.rs:53:5
   |
53 |     env,
   |     ^^^
...
56 |     process::exit,
   |     ^^^^^^^^^^^^^
   |
   = note: `#[warn(unused_imports)]` on by default