Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce visualization #347

Merged
merged 23 commits into from
Dec 13, 2024
Merged

Introduce visualization #347

merged 23 commits into from
Dec 13, 2024

Conversation

ytdHuang
Copy link
Member

@ytdHuang ytdHuang commented Dec 11, 2024

Checklist

Thank you for contributing to QuantumToolbox.jl! Please make sure you have finished the following tasks before opening the PR.

  • Please read Contributing to QuantumToolbox.jl.
  • Any code changes were done in a way that does not break public API.
  • Appropriate tests were added and tested locally by running: make test.
  • Any code changes should be julia formatted by running: make format.
  • All documents (in docs/ folder) related to code changes were updated and able to build locally by running: make docs.
  • (If necessary) the CHANGELOG.md should be updated (regarding to the code changes) and built by running: make changelog.

Request for a review after you have completed all the tasks. If you have not finished them all, you can also open a Draft Pull Request to let the others know this on-going work.

Description

Most of the things are done in PR #292, this PR will focus on the CI pipeline config setup for CairoMakie extension.

Related issues or PRs

PR #292
close #86

@ytdHuang ytdHuang changed the title Dev/visualization Introduce visualization Dec 11, 2024
@ytdHuang ytdHuang marked this pull request as ready for review December 12, 2024 07:01
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

Attention: Patch coverage is 97.56098% with 1 line in your changes missing coverage. Please review.

Project coverage is 93.37%. Comparing base (e754148) to head (9dafde3).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
ext/QuantumToolboxCairoMakieExt.jl 97.43% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #347      +/-   ##
==========================================
+ Coverage   93.31%   93.37%   +0.06%     
==========================================
  Files          38       40       +2     
  Lines        2647     2688      +41     
==========================================
+ Hits         2470     2510      +40     
- Misses        177      178       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ytdHuang
Copy link
Member Author

Weird, everything run on my local PC is fine.

@albertomercurio
Copy link
Member

There are also the commits of the previous PR.

@ytdHuang
Copy link
Member Author

There are also the commits of the previous PR.

Because they are not merged to main yet.

@albertomercurio albertomercurio merged commit 38a473c into main Dec 13, 2024
16 of 18 checks passed
@ytdHuang ytdHuang deleted the dev/visualization branch December 13, 2024 09:12
labay11 pushed a commit to labay11/QuantumToolbox.jl that referenced this pull request Dec 22, 2024
* Add Wigner plotting via CairoMakie

* CairoMakie default lib

* docs

* formatting

* Fix typo

* Add error handling for unavailable plotting libraries in plot_wigner function

* Docs

* Update CairoMakie dependency and add CairoMakie extension tests

* Update documentation to reflect changes in Wigner function plotting and computation

* formatting

* Update changelog

* Improve docs

* Update CairoMakie imports and change axis labels

* fix CHANGELOG

* setup CI pipeline config for `CairoMakie` extension

* rebase accidently removed lines

* fix typo

* add `CairoMakie` extension doc page

* fix typo

* minor change in docs

* minor change in docs

---------

Co-authored-by: Lorenzo Fioroni <[email protected]>
Co-authored-by: Alberto Mercurio <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plot wigner
3 participants