-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Wigner plotting via CairoMakie #292
Conversation
By the way, is it also possible to generate our logo with this function ? |
I would say yes. Indeed, it would be a good thing to apply this function directly in the tutorial of the logo. |
It is straightforward to use this function to follow the logo tutorial up to where dissipation is included ("Introducing some decoherence"). However, I don't see an easy way to generate the full logo with the three julia colors, as that's not an heatmap anymore. In the tutorial you manually combine the colors to have a grid of RGB values displayed with Ideally, I would now add documentation and tests and fix a couple of minor details before pushing a new version. If you have any advice on how follow the tutorial till the end, though, I'd be happy to implement it. |
@albertomercurio |
As Lorenzo said, we can use But still, it is a good idea to directly using it in the tutorial. |
Then sorry for the delay in bringing the PR to its final form. I hope I'll be able to finish adding tests and docs in the following days. |
It's okay, take your time. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev/visualization #292 +/- ##
===================================================
Coverage ? 9.23%
===================================================
Files ? 40
Lines ? 2641
Branches ? 0
===================================================
Hits ? 244
Misses ? 2397
Partials ? 0 ☔ View full report in Codecov by Sentry. |
I have changed the target branch from I think the extension test structure and also the corresponding CI pipeline configs need to be modified, which I can do it afterwards. Apart from that, I have a few more comments below. |
Thanks @ytdHuang for your input. I updated the docs to match your suggestions. |
How exactly do you want to change the structure? I can also try to do it directly in this PR |
It would be better to make this extension be an independent test group, so that the original core tests doesn't need to install I can do it afterwards. |
Checklist
make test
.julia
formatted by running:make format
.docs/
folder) related to code changes were updated and able to build locally by runningmake docs
.Description
This PR introduces plotting capabilities in QuantumToolbox (starting from the
plot_wigner
function implemented in QuTip).To reduce the impact on loading time, I wrote an extension for the CairoMakie library, such that the necessary code is not loaded by default. Moreover, this allows extending the scheme to additional plotting libraries like PyPlot or Plots (although I haven't done it).
The
plot_wigner
function implements 2D and 3D projections of the Wigner and reproduces QuTip's output as faithfully as possible.Related issues or PRs
fix #86