Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open external link: Missing link address #820

Closed
sdicke opened this issue Mar 25, 2022 · 2 comments · Fixed by #859
Closed

Open external link: Missing link address #820

sdicke opened this issue Mar 25, 2022 · 2 comments · Fixed by #859
Assignees
Labels
bug/fix Quaternion doesn't work as expected

Comments

@sdicke
Copy link
Contributor

sdicke commented Mar 25, 2022

Description

When opening a Matrix-external link, there is a dialog displayed. At most in the German translation of the GUI, there is displayed „% 1“ instead of a URI.

Steps to reproduce

  • Click on a link addressing addressing a URI not associated with a Matrix resource.
  • A dialog request the permission to open the link in an external application which does not contain the link get displayed.

I would expect that such kind of dialogs would display the address of the resource to open in the external application.

The following was logged (the actual link is replaced with $$$):

QString::arg: Argument missing: Eine externe Anwendung wird geöffnet, um einen Nicht-Matrix-Link zu besuchen:

% 1

Ist das richtig?, $$$
quotient.jobs: 200 <- GET $$$

Version information

  • Quaternion version: v0.0.95.1
  • Qt version: 5.15.2.
  • Install method: zypper: packages matrix-quaternion and matrix-quaternion-lang
  • Platform: openSUSE Tumbleweed
@KitsuneRal
Copy link
Member

Thanks for reporting. Right, there's a typo in the German translation - it has an extra whitespace between % and 1, thereby breaking the %1 placeholder that would normally be replaced with the URL. It is already fixed in the translation management system and is pending an (overdue) export to the source code.

@KitsuneRal KitsuneRal added the bug/fix Quaternion doesn't work as expected label Mar 27, 2022
@KitsuneRal KitsuneRal self-assigned this Mar 27, 2022
@KitsuneRal KitsuneRal linked a pull request Apr 6, 2023 that will close this issue
@KitsuneRal
Copy link
Member

This is fixed in 0.0.96 beta.

@KitsuneRal KitsuneRal moved this to Version 0.0.96 - Done in Quaternion 1 Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug/fix Quaternion doesn't work as expected
Projects
Status: Version 0.0.96 - Done
Development

Successfully merging a pull request may close this issue.

2 participants