Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Userscripts with quotes in their names break #401

Closed
MynockSpit opened this issue Dec 7, 2022 · 1 comment · Fixed by #560
Closed

Userscripts with quotes in their names break #401

MynockSpit opened this issue Dec 7, 2022 · 1 comment · Fixed by #560
Labels
bug Something isn't working

Comments

@MynockSpit
Copy link

Scripts w/ quotes (") in their usernames fail to get injected.

Reproduction steps:

  1. Create a new script with quotes in the name.
    // ==UserScript==
    // @name          My "Quoted" Script
    // @match         <all_urls>
    // @exclude-match *://*.google.com/*
    // @noframes
    // ==/UserScript==
    
    console.log(`This will never trigger b/c of the "Quoted" bit in the name.`);
    
  2. Observe the following error and that the log isn't run.

image

I believe the issue lies here:

const US_filename = "${filename}";

@ACTCD ACTCD added bug Something isn't working javascript labels Dec 7, 2022
@mrienstra
Copy link

New location: https://github.com/quoid/userscripts/blob/f108809/xcode/Safari-Extension/Resources/content.js#L257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants