-
Notifications
You must be signed in to change notification settings - Fork 779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase out dist/ folder in favour of qunit/ #1133
Comments
cc @jzaefferer. You might know the reason for this. I honestly don't remember. |
@platinumazure This might become the new turtle on the tree. It's there by some reason. |
@platinumazure At the moment, neither ReleaseLong ago (before 1.13.0, and even longer ago when it was still part of jquery's test directory) QUnit was maintained as a single file in the I first moved away from this in 6f8f6c3 (pull #480, issue #378). Since then, we've no longer had a
It was proposed by @jzaefferer in #480 (comment) that we keep supporting this by committing the We were going to only keep doing that for new releases until 2.0, but I guess we forgot! DevelopmentDuring local development, grunt will generate a distribution file in As far as I know, |
@Krinkle thanks for the background, much appreciated! At this point, since we ship So, the question then is, do we need to keep |
@trentmwillis Sounds good. I wasn't aware that we also use |
I'm a bit confused about why we maintain both a
dist/
folder (for web use and development) but also create aqunit/
folder when releasing and/or for Node. Can we simplify this process?Long-term, my preference would be to just export a canonical "core QUnit" file and also have wrappers for executing QUnit in different contexts. (In a different issue, I might have referred to those wrappers as "runners", to contract with "reporters".) But on top of that, it would be nice if we could keep the folder structure consistent if at all possible.
The text was updated successfully, but these errors were encountered: