From a604759336006f728775492b4536451190986b67 Mon Sep 17 00:00:00 2001 From: Dirk Stolle Date: Fri, 2 Jun 2023 00:09:33 +0200 Subject: [PATCH] Replace unmaintained actions-rs/* actions in CI workflows Basically all of the `actions-rs/*` actions are unmaintained. See for more information. Due to their age they generate several warnings in CI runs. To get rid of those warnings the occurrences of `actions-rs/toolchain` are replaced by `dtolnay/rust-toolchain`, and the occurrences of `actions-rs/cargo` are replaced by direct invocations of `cargo`. --- .github/workflows/codecov.yml | 6 +---- .github/workflows/rust.yml | 49 +++++++---------------------------- 2 files changed, 11 insertions(+), 44 deletions(-) diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml index 9238896c3..27d6719f9 100644 --- a/.github/workflows/codecov.yml +++ b/.github/workflows/codecov.yml @@ -9,11 +9,7 @@ jobs: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - uses: actions-rs/toolchain@v1 - with: - profile: minimal - toolchain: stable - override: true + - uses: dtolnay/rust-toolchain@stable - uses: taiki-e/install-action@cargo-llvm-cov - run: cargo llvm-cov --all-features --workspace --lcov --output-path lcov.info - name: Upload coverage to Codecov diff --git a/.github/workflows/rust.yml b/.github/workflows/rust.yml index 68de010e1..0dc2eb913 100644 --- a/.github/workflows/rust.yml +++ b/.github/workflows/rust.yml @@ -45,64 +45,35 @@ jobs: steps: - uses: actions/checkout@v3 - - uses: actions-rs/toolchain@v1 + - uses: dtolnay/rust-toolchain@master with: - profile: minimal toolchain: ${{ matrix.rust }} - override: true - uses: Swatinem/rust-cache@v1 - - uses: actions-rs/cargo@v1 - with: - command: build - args: --all-targets - - uses: actions-rs/cargo@v1 - with: - command: test - - uses: actions-rs/cargo@v1 + - run: cargo build --all-targets + - run: cargo test + - run: cargo test --manifest-path fuzz/Cargo.toml if: ${{ matrix.rust }} == "stable" - with: - command: test - args: --manifest-path fuzz/Cargo.toml msrv: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - uses: actions-rs/toolchain@v1 - with: - profile: minimal - toolchain: 1.63.0 - override: true + - uses: dtolnay/rust-toolchain@1.63.0 - uses: Swatinem/rust-cache@v1 - - uses: actions-rs/cargo@v1 - with: - command: check - args: --lib --all-features -p quinn-udp -p quinn-proto -p quinn + - run: cargo check --lib --all-features -p quinn-udp -p quinn-proto -p quinn lint: runs-on: ubuntu-latest steps: - uses: actions/checkout@v3 - - uses: actions-rs/toolchain@v1 + - uses: dtolnay/rust-toolchain@stable with: - profile: minimal - toolchain: stable - override: true components: rustfmt, clippy - uses: Swatinem/rust-cache@v1 - - uses: actions-rs/cargo@v1 - with: - command: fmt - args: --all -- --check - - uses: actions-rs/cargo@v1 - with: - command: clippy - args: --all-targets -- -D warnings - - uses: actions-rs/toolchain@v1 + - run: cargo fmt --all -- --check + - run: cargo clippy --all-targets -- -D warnings + - uses: dtolnay/rust-toolchain@stable with: - profile: minimal - toolchain: stable - override: true components: clippy - name: doc run: cargo doc --no-deps --document-private-items