Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce preview size for large Jupyter notebooks #1822

Merged
merged 4 commits into from
Sep 24, 2020
Merged

Reduce preview size for large Jupyter notebooks #1822

merged 4 commits into from
Sep 24, 2020

Conversation

akarve
Copy link
Member

@akarve akarve commented Sep 24, 2020

Lambda only allows us to send a max of 6MB back. Even though we GZIP, notebooks with lots of images won't don't come under 6MB.

@codecov-commenter
Copy link

codecov-commenter commented Sep 24, 2020

Codecov Report

Merging #1822 into master will increase coverage by 0.02%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1822      +/-   ##
==========================================
+ Coverage   89.46%   89.49%   +0.02%     
==========================================
  Files          62       62              
  Lines        7215     7233      +18     
==========================================
+ Hits         6455     6473      +18     
  Misses        760      760              
Flag Coverage Δ
#api-python 87.87% <ø> (ø)
#lambda 92.32% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
lambdas/preview/index.py 98.26% <100.00%> (+0.11%) ⬆️
lambdas/preview/test/test_index.py 99.70% <100.00%> (+<0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 242f54c...585437b. Read the comment docs.

@akarve akarve merged commit a5945a1 into master Sep 24, 2020
@akarve akarve deleted the big-nb branch September 24, 2020 23:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants