-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing SVG icon for 'code' toolbar format #998
Comments
Do you think the |
Ideally they would be two different icons since they do different things (apply block level formatting vs inline formatting), but I recognize it's difficult to convey that clearly with two versions of a very similar icon. |
@jhchen This commit is just a quick fix for the missing icon. Better two times the same icon as no icon ;) In general it would be good if there are two different icons for 'code' and 'code-block'. |
Yes I think different icons will be difficult so let's go with this for now. |
Hi I've made a different icon for code-block (inspired from slack code-block icon) |
As seen on http://codepen.io/anon/pen/wzgYqX, the 'code' format does not have an SVG icon. It does properly format the text, and there is also a 'code-block' icon for block level formatting.
The text was updated successfully, but these errors were encountered: