-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
quill.getBounds() returns incorrect position on an empty bullet #765
Comments
I think f53183f also fixed this issue. Can you confirm? |
Sure. What's the best way for me to test pre-release versions of Quill within my app? For my app I normally just use npm to install specific quill releases (ie. npm install [email protected]). I've done Quill development as well via a fork of Quill and just testing within the development Quill test app. But is there a way I can either install the pre-release version via npm or link the development version to my main app? |
Just pushed a new beta version so feel free to test the standard way. Otherwise you'd normally have to set up the dev environment and build a local copy. |
Ok so you do now get the right bounds for a non-indented bullet in Quill 1.0 Beta 9. But the bounds are still incorrect for multiple-levels of indent. Regardless of whether you indent more, getBounds() is returning the position as if it was a non-indented bullet. |
Hmm this seems to be working for me. Are you using the updated stylesheet as well? |
Yes, I updated the stylesheet as well. The specific issue is when the bullet is empty. Take a look at this code pen: http://codepen.io/sachinrekhi/pen/grvZwv |
Okay sorry missed the empty detail. |
When you call quill.getBounds() when you are on an empty bullet, it incorrectly returns the location as the beginning of the line instead of to the right of the bullet where the cursor in fact is.
This is a regression from Quill 0.20.1
Steps for Reproduction
Expected behavior:
getBounds() returns the position of the current cursor, which is to the right of the bullet point
Actual behavior:
getBounds() returns the position at the beginning of the line, which is to the left of the bullet point
Platforms:
Chrome 51 on Mac 10.11
Version:
Quill 1.0 Beta 6
The text was updated successfully, but these errors were encountered: