Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Focus issues when scrolled down in IE10+ #415

Closed
magus opened this issue Jul 15, 2015 · 4 comments
Closed

Focus issues when scrolled down in IE10+ #415

magus opened this issue Jul 15, 2015 · 4 comments

Comments

@magus
Copy link

magus commented Jul 15, 2015

#221

This issue above still seems to be present in IE10+, you can easily reproduce it on the http://quilljs.com/ homepage examples.

Perhaps we can do a fix similar to the pasting scroll issue (#143) and just quickly scroll back to the selected content. Calling preventDefault for the buttons will work just fine for the buttons, but not the select items due to their unique nature.

@jhchen
Copy link
Member

jhchen commented Jul 23, 2015

I'm not able to reproduce this in IE10 or IE11. Can you post steps for reproduction?

@jhchen jhchen closed this as completed Jul 23, 2015
@jhchen jhchen reopened this Jul 23, 2015
@magus
Copy link
Author

magus commented Jul 23, 2015

Go to quilljs.com
Scroll down to bottom of text editor
Type in some content, select it, then click the bold formatting button or select a new font from the dropdown
The view will jump back to the top (due to the focus call?)

@muhleder
Copy link

We're seeing this as well, using something like this to fix it.
muhleder@ca9cd7b

@Pavek
Copy link

Pavek commented Mar 30, 2016

I can still reproduce it with Quill 0.20.1 on Win7/IE11.

The simplest testcase:
Go to http://quilljs.com/ in IE11
Scroll editor area down to bottom
Click any button: Bold/Italic etc..
=> The editor area is immediately scrolled to the top (this is bad because you might have edited something at the bottom, obviously)

Looks like this is caused by: https://github.com/quilljs/quill/blame/0.20.1/src/modules/toolbar.coffee#L59

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants