Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align numerical type priority order on the search side. #2088

Merged
merged 3 commits into from
Jun 11, 2023

Conversation

fmassot
Copy link
Contributor

@fmassot fmassot commented Jun 11, 2023

#1978 partially fixes #1956: we should infer number in the following order i64, u64, f64. But when building a query, we call convert_to_fast_value_and_get_term to infer the type and this function has the following u64, i64, f64.

This PR fixes the ordering and starts with i64.

TODO:

  • fix test
  • add a test to check the consistency between ordering at indexing and search.

@codecov-commenter
Copy link

Codecov Report

Merging #2088 (0cb5320) into main (7220df8) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main    #2088      +/-   ##
==========================================
- Coverage   94.38%   94.38%   -0.01%     
==========================================
  Files         321      321              
  Lines       60384    60389       +5     
==========================================
+ Hits        56996    57000       +4     
- Misses       3388     3389       +1     
Impacted Files Coverage Δ
src/core/json_utils.rs 99.58% <100.00%> (ø)
src/query/query_parser/query_parser.rs 94.89% <100.00%> (+0.01%) ⬆️

... and 1 file with indirect coverage changes

@fulmicoton
Copy link
Collaborator

thanks! sorry for messing up

@fmassot fmassot force-pushed the fmassot/align-type-priorities-for-json-numbers branch from 3a603d6 to 0702394 Compare June 11, 2023 19:47
@fmassot fmassot merged commit 924fc70 into main Jun 11, 2023
@fmassot fmassot deleted the fmassot/align-type-priorities-for-json-numbers branch June 11, 2023 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Align type priority order for json numbers
3 participants