tokenizer-api: reduce Tokenizer overhead #2062
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PSeitz
force-pushed
the
tokenizer_api
branch
2 times, most recently
from
8a59b38 to
9c95c3d
Compare
adamreichold
reviewed
Jun 1, 2023
tokenizer-api/src/lib.rs
Outdated
| /// Creates a token stream for a given `str`. | ||
| fn token_stream<'a>(&self, text: &'a str) -> Self::TokenStream<'a>; | ||
| fn token_stream<'a, 'b>(&'b mut self, text: &'a str) -> Self::TokenStream<'a, 'b>; |
There was a problem hiding this comment.
Is it really helpful to have two lifetimes here instead of binding both to the presumably shorter one, e.g.
fn token_stream<'a>(&'a mut self, text: &'a str) -> Self::TokenStream<'a>;and let the general case be handled via covariance?
There was a problem hiding this comment.
Good point, one lifetime is enough
Previously a new `Token` for each text encountered was created, which contains `String::with_capacity(200)` In the new API the token_stream gets mutable access to the tokenizer, this allows state to be shared (in this PR Token is shared). Ideally the allocation for the BoxTokenStream would also be removed, but this may require some lifetime tricks.
PSeitz
force-pushed
the
tokenizer_api
branch
2 times, most recently
from
24a18f0 to
69c9277
Compare
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #2062 +/- ##
==========================================
- Coverage 94.38% 94.38% -0.01%
==========================================
Files 319 319
Lines 60040 60091 +51
==========================================
+ Hits 56670 56714 +44
- Misses 3370 3377 +7
|
fulmicoton
approved these changes
Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously a new
Tokenfor each text encountered was created, whichcontains
String::with_capacity(200)In the new API the token_stream gets mutable access to the tokenizer,
this allows state to be shared (in this PR Token is shared).
Ideally the allocation for the BoxTokenStream would also be removed, but
this may require some lifetime tricks.
#1654