Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add seperate tokenizer manager for fast fields #2019

Merged
merged 2 commits into from
May 8, 2023
Merged

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented May 1, 2023

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented May 1, 2023

Codecov Report

Merging #2019 (029f769) into main (ba309e1) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #2019      +/-   ##
==========================================
- Coverage   94.42%   94.39%   -0.03%     
==========================================
  Files         319      319              
  Lines       59216    59142      -74     
==========================================
- Hits        55914    55830      -84     
- Misses       3302     3312      +10     
Impacted Files Coverage Δ
src/schema/text_options.rs 95.87% <ø> (ø)
src/core/index.rs 87.14% <100.00%> (+0.23%) ⬆️
src/fastfield/mod.rs 100.00% <100.00%> (ø)
src/indexer/segment_writer.rs 97.78% <100.00%> (+<0.01%) ⬆️

... and 16 files with indirect coverage changes

src/core/index.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@fulmicoton fulmicoton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved but can you align naming one way or another before merging?

@PSeitz PSeitz force-pushed the two_tokenizer_managers branch from 565957d to 029f769 Compare May 8, 2023 08:01
@PSeitz PSeitz merged commit 4ee1b5c into main May 8, 2023
@PSeitz PSeitz deleted the two_tokenizer_managers branch May 8, 2023 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants