Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add percentiles aggregations #1984

Merged
merged 5 commits into from
Apr 7, 2023
Merged

add percentiles aggregations #1984

merged 5 commits into from
Apr 7, 2023

Conversation

PSeitz
Copy link
Contributor

@PSeitz PSeitz commented Apr 6, 2023

add percentiles aggregation
fix disabled agg benchmark

Note: temporary github dependency (wait for upstream merge or publish duplicate)

test aggregation::agg_bench::bench::bench_aggregation_percentiles_f64                                                    ... bench:  16,975,931 ns/iter (+/- 129,979)
test aggregation::agg_bench::bench::bench_aggregation_percentiles_f64_multi                                              ... bench:  23,931,146 ns/iter (+/- 1,874,794)
test aggregation::agg_bench::bench::bench_aggregation_percentiles_f64_opt                                                ... bench:  22,435,085 ns/iter (+/- 217,680)

closes #1763

add percentiles aggregation
fix disabled agg benchmark
@PSeitz PSeitz requested a review from fulmicoton April 6, 2023 12:23
@codecov-commenter
Copy link

Codecov Report

Merging #1984 (5ce294c) into main (5eb1217) will increase coverage by 0.05%.
The diff coverage is 93.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main    #1984      +/-   ##
==========================================
+ Coverage   94.50%   94.55%   +0.05%     
==========================================
  Files         317      319       +2     
  Lines       58587    59575     +988     
==========================================
+ Hits        55369    56333     +964     
- Misses       3218     3242      +24     
Impacted Files Coverage Δ
src/aggregation/agg_result.rs 78.82% <0.00%> (-5.72%) ⬇️
src/aggregation/error.rs 100.00% <ø> (ø)
src/aggregation/metric/stats.rs 97.71% <ø> (-0.01%) ⬇️
src/aggregation/mod.rs 93.73% <ø> (ø)
src/aggregation/agg_req.rs 93.95% <66.66%> (-0.68%) ⬇️
src/aggregation/metric/percentiles.rs 91.29% <91.29%> (ø)
src/aggregation/intermediate_agg_result.rs 97.31% <98.82%> (+0.14%) ⬆️
src/aggregation/agg_bench.rs 100.00% <100.00%> (ø)
src/aggregation/agg_req_with_accessor.rs 98.57% <100.00%> (+0.13%) ⬆️
src/aggregation/agg_tests.rs 100.00% <100.00%> (ø)
... and 3 more

... and 9 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@PSeitz PSeitz merged commit 41af707 into main Apr 7, 2023
@PSeitz PSeitz deleted the agg_extended_stats branch April 7, 2023 05:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

percentiles metric aggregation
3 participants