add memory check for term agg #1957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fulmicoton
reviewed
Mar 24, 2023
| @@ -8,7 +8,7 @@ use super::collector::DEFAULT_MEMORY_LIMIT; | |||
| use super::{AggregationError, DEFAULT_BUCKET_LIMIT}; | |||
| use crate::TantivyError; | |||
|
|
|||
| /// An estimate for memory consumption | |||
| /// An estimate for memory consumption. Non recursive | |||
There was a problem hiding this comment.
what does non recursive mean here?
There was a problem hiding this comment.
That it does not cover sub elements, e.g.
Vec<Box<dyn SubCollector>>
- We would need to add trait bounds on the sub elements
- It would be much slower to traverse whole trees
fulmicoton
approved these changes
Mar 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.