-
-
Notifications
You must be signed in to change notification settings - Fork 696
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for u64,i64,f64 fields in term aggregation #1883
Conversation
737bb4d
to
a04cbbc
Compare
impl Eq for Key {} | ||
impl std::hash::Hash for Key { | ||
fn hash<H: std::hash::Hasher>(&self, state: &mut H) { | ||
core::mem::discriminant(self).hash(state); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This won't work well if someone indexes different values of f64::NAN
and then does an aggregation on it.
Do we care about this use case?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's forbid NaN entirely. If you really want to keep them we can work at least map them upon input to whatever u64_to_f64(0u64)
is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TIL about Discriminant
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## main #1883 +/- ##
========================================
Coverage 94.64% 94.65%
========================================
Files 301 301
Lines 54924 55038 +114
========================================
+ Hits 51985 52095 +110
- Misses 2939 2943 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
a04cbbc
to
1737d42
Compare
40f2b7f
to
6c448d3
Compare
960c03f
to
6ad2d1e
Compare
No description provided.