Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reach parity with core tantivy #45

Open
petr-tik opened this issue Sep 22, 2019 · 1 comment
Open

Reach parity with core tantivy #45

petr-tik opened this issue Sep 22, 2019 · 1 comment

Comments

@petr-tik
Copy link
Contributor

Going through the quickstart guide I noticed, the cli offers 2 field options - int or text, while core tantivy offers text, u64, i64, DateTime, Facet and Bytes.

Most likely this will be the first point of call for new users, who want to check tantivy out.

Going forward, if tantivy-cli wants to stay a real and relevant part of tantivy, we will need to invest in continuous feature parity.

It might be easier if we subsume tantivy-cli/src under bin/tantivy-cli in core tantivy. This will help us check, if new fields are included in cli application as well as extend the API endpoint.

We can also use CI to cross-compile and deploy ready tantivy-cli binaries for people to download and play around with.

@petr-tik
Copy link
Contributor Author

It looks like some code from the cli can and should be integrated back into core. Example below

https://github.com/tantivy-search/tantivy-cli/blob/develop/src/commands/new.rs#L46-L54

I cannot such restrictions in core tantivy, so this is either irrelevant or needs to be behind an Error value in core

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant