Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support X-Correlation-ID in header #5312

Open
PSeitz opened this issue Aug 13, 2024 · 2 comments
Open

Support X-Correlation-ID in header #5312

PSeitz opened this issue Aug 13, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@PSeitz
Copy link
Contributor

PSeitz commented Aug 13, 2024

Add support for X-Correlation-ID in the header.

The X-Correlation-ID is an id that gets passed by a client and is getting printed in the logs.
This allows end to end tracing of requests across systems.

@PSeitz PSeitz added the enhancement New feature or request label Aug 13, 2024
@rdettai
Copy link
Contributor

rdettai commented Nov 20, 2024

could be interesting to use trace propagation with https://github.com/tokio-rs/tracing-opentelemetry

@fulmicoton
Copy link
Contributor

fulmicoton commented Nov 22, 2024

So we do have trace propagation using opentelemetry. I think Pascal means (I am not sure) putting the trace in logs, so that we can look at logs, get a request id, and check at the trace.

I wrote code to extract the trace id a few years ago. I ended up trashing it assuming we would never use it. (Also the code to extract it was pretty ugly)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants