Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Static table for access-control-request-headers (index 80) #19

Closed
tcfw opened this issue Oct 29, 2020 · 2 comments · Fixed by #20
Closed

Static table for access-control-request-headers (index 80) #19

tcfw opened this issue Oct 29, 2020 · 2 comments · Fixed by #20
Labels
bug Something isn't working

Comments

@tcfw
Copy link
Contributor

tcfw commented Oct 29, 2020

Found an issue when trying to use CORS via HTTP3 (lucas-clemente/quic-go) that the "allow-control-request-headers" was being interpreted as the "allow-control-expose-headers" when the request was coming from chrome 86.0.4240.111 and firefox 82.0.

I've checked the most recent draft-ietf-quic-qpack-19 and found in the static table that it should be coming in as index 80 but looking here it's paired with index 79.

@marten-seemann
Copy link
Member

You mean that this line is incorrect, right?
https://github.com/marten-seemann/qpack/blob/f1218f693233709a863ecf6097f6aa639f58d200/static_table.go#L84

Would you mind sending us a PR to fix it (both in this line and in the encoderMap table)?

@tcfw
Copy link
Contributor Author

tcfw commented Oct 29, 2020

That's the one, I believe.

Will send through shortly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants