Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Libsecret Support #9

Open
martininsulander opened this issue Oct 16, 2023 · 6 comments
Open

Libsecret Support #9

martininsulander opened this issue Oct 16, 2023 · 6 comments
Labels
enhancement New feature or request

Comments

@martininsulander
Copy link

Hi,
I got the impression that goldwarden integrates with Secret service?
This is from it integrating with the desktop environment, and from a comment on bitwarden forum.

However, I don't see it on the dbus, so, is secret service/libsecret supported?

In that case, any suggestion on how to trouble shoot it missing?

And otherwise, I would like to add a feature request for it.

@quexten
Copy link
Owner

quexten commented Oct 16, 2023

At the moment, there is no libsecret support. The comment must have gotten something mixed up. I had a brief discussion about this here: #2
But to be honest I have not yet had the time to take a closer look at implementing this.

@quexten quexten added the enhancement New feature or request label Oct 16, 2023
@quexten quexten changed the title Secret service support? Libsecret Support Oct 16, 2023
@martininsulander
Copy link
Author

Thank you for the answer.
Understand that time is lacking, the following is for inspiration, not pressure.

So far this project looks very interesting. And as libsecret/secret service is the closest to a standard for password management in desktops, and quite wide adopted, I think it would fit this project well. Opening up for general password saving and completion in programs and browsers.
I have found some go-implementations, but as I'm not into that language, I won't try to figure out what is good.

Thanks for the good job, and I keep my fingers crossed that it eventually happens 😃

@quexten
Copy link
Owner

quexten commented Dec 31, 2023

Interesting related topic: https://gitlab.gnome.org/gnumdk/passbook/-/issues/17

If the above were to move forward, there would be a good standardized way to access per-url credentials, which would make libsecret support immensely useful. Sadly, there has not been too much movement on that front just yet.

@quexten
Copy link
Owner

quexten commented Dec 31, 2023

Or - even better - flatpak/xdg-desktop-portal#311

@fschaupp
Copy link

KeepassXC Desktop application seems to did ich here: keepassxreboot/keepassxc@e121f4b
With the FeatureBounty keepassxreboot/keepassxc#1403

@TermoZour
Copy link

Would libsecret support allow Goldwarden to use the GNOME Keyring for authentication instead of PIN?

For example, GNOME DejaDup uses the Keyring to store a key which I think is derived from my "encrypt backup" password, so when a backup needs to be made, DejaDup will use the key in the Keyring to encrypt my backups.

Would Goldwarden libsecret in order to provide such functionality? I tried finding an Issue Request about "Login with Keyring instead of PIN" but couldn't find any. Is it more or less secure than the current PIN implementation?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants