Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate the Data.Text.Prettyprint.* modules #203

Merged
merged 6 commits into from
Sep 1, 2021
Merged

Conversation

sjakobi
Copy link
Collaborator

@sjakobi sjakobi commented Aug 19, 2021

Context: #110

TODO:

@sjakobi
Copy link
Collaborator Author

sjakobi commented Aug 19, 2021

[ ] Implement this recommendation: prettyprinter has very long module names #110 (comment)

Actually I think that removing the old modules from the module overview might cause confusion. We can consider doing this in a few months once most users should be well-aware of the deprecation.

@sjakobi sjakobi marked this pull request as ready for review August 19, 2021 12:50
@quchen quchen self-requested a review August 31, 2021 08:59
@quchen
Copy link
Owner

quchen commented Aug 31, 2021

LGTM! The new hierarchy looks much better. Looks like Prettyprinter is slowly becoming the standard prettyprinter! :-)

@sjakobi sjakobi merged commit 880f41e into master Sep 1, 2021
@sjakobi sjakobi deleted the sjakobi/deprecate-dtp branch September 1, 2021 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants