Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing identity validation when looking for trader information #1

Open
sallymoc opened this issue Dec 3, 2024 · 2 comments
Open
Labels
bug Something isn't working

Comments

@sallymoc
Copy link

sallymoc commented Dec 3, 2024

When entering data in the public id field in the Home screen and tapping "Lookup Trader" the app is not validating the identity entered is correct

image

this gives the following result
image

Whether the user does the search or modifies the URL manually (https://qx.qubic.org/entities/), the app should validate the entity is valid (length 60 and the checksum of the last 4 characters) before to call any service in the backend

@sallymoc sallymoc added the bug Something isn't working label Dec 3, 2024
@sallymoc sallymoc moved this to Backlog in Qx Kanban Board Dec 3, 2024
@sallymoc sallymoc moved this from Backlog to Ready in Qx Kanban Board Dec 10, 2024
@qubicmio
Copy link

The backend returns a HTTP 400 error (Bad request) in this case. Maybe it is enough to use the status code for identifying invalid IDs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Ready
Development

No branches or pull requests

3 participants
@sallymoc @qubicmio and others