blobuploadcleanupworker: Add BLOBUPLOAD_DELETION_DATE_THRESHOLD (PROJQUAY-2915) #1022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleesc
requested changes
Dec 7, 2021
| @@ -15,7 +15,7 @@ | |||
|
|
|||
| logger = logging.getLogger(__name__) | |||
|
|
|||
| DELETION_DATE_THRESHOLD = timedelta(days=2) | |||
| DELETION_DATE_THRESHOLD = timedelta(hours=12) | |||
There was a problem hiding this comment.
Can we make this configurable instead. Something like BLOB_UPLOAD_DELETION_DATE_THRESHOLD.
This way we can keep the current value as default, but allow it to be shorter or longer for others.
Not too dissimilar to how BLOBUPLOAD_CLEANUP_FREQUENCY is being set.
…QUAY-2915) Added BLOBUPLOAD_DELETION_DATE_THRESHOLD option to configure TTL on orphaned blobs.
bcaton85
force-pushed
the
adjust-deletion-threshold
branch
from
e396e4e to
8bd5c17
Compare
bcaton85
changed the title
bcaton85
added a commit
to bcaton85/quay
that referenced
this pull request
Dec 7, 2021
…QUAY-2915) (quay#1022) Added BLOBUPLOAD_DELETION_DATE_THRESHOLD option to configure TTL on orphaned blobs.
flavianmissi
pushed a commit
that referenced
this pull request
Dec 7, 2021
…QUAY-2915) (#1022) (#1023) Added BLOBUPLOAD_DELETION_DATE_THRESHOLD option to configure TTL on orphaned blobs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the BLOBUPLOAD_DELETION_DATE_THRESHOLD internal property to configure the TTL on orphaned blobs.