Switch to NVD JSON feed and include CVSSv3 #645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The JSON feed provides some values that are not available in the XML feed such as CVSSv3.
skelterjohn
reviewed
Oct 17, 2018
jzelinskie
suggested changes
Oct 18, 2018
|
I'd also like to pass through the CVSSv3 expoloitability score and impact score, I'm adding a commit for that now. |
jzelinskie
reviewed
Oct 19, 2018
jzelinskie
approved these changes
Oct 22, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The NVD JSON feed is still "beta". According to the NVD changlog the last breaking change (a field rename which would not have affected this code) happened 2017-12-18. CVSSv3 is only in the JSON feed.
Some things in the feed relevant to Clair have changed:
PublishedDateTimehas changed from2018-01-10T17:29:00.930-05:00to2018-01-10T22:29Z.The changes in this PR are meant to be backwards compatible:
NVDmetadataCVSSv2remains unchanged.PublishedDateTimeis still inNVDmetadataCVSSv2even though it isn't specific to CVSSv2.Metadatareturns nil if CVSSv2 isn't available (and this now has a test).