Driver: Add proxy support #485
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable the use of HTTP_PROXY and HTTPS_PROXY variables when downloading layers
jzelinskie
approved these changes
Nov 7, 2017
|
Awesome thanks for the contribution! |
KeyboardNerd
pushed a commit
to KeyboardNerd/clair
that referenced
this pull request
Feb 2, 2018
Driver: Add proxy support
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I have to use a proxy on my servers running Clair.
Setting HTTP_PROXY variable works fine for the updater since http.Get and then DefaultTransport is used.
On the other hand, as the imagefmt driver declares a custom http.Transport to enable/disable certificate verification, it does not support HTTP_PROXY. I modified it to have the same behavior as the updater.