notifier: Refactor and add client certificate authentification support. #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Quentin-M
force-pushed
the
notifier_tls
branch
4 times, most recently
from
6cafe4f to
8260b17
Compare
| // A Notification represents the structure of the notifications that are sent by a Notifier. | ||
| type Notification struct { | ||
| Name, Type string | ||
| Content interface{} |
There was a problem hiding this comment.
Eventually we should change this type to something like json.Marshaller.
Quentin-M
force-pushed
the
notifier_tls
branch
from
8260b17 to
7c70362
Compare
|
Updated. |
Quentin-M
force-pushed
the
notifier_tls
branch
from
7c70362 to
7e6133a
Compare
| func (notifier *HTTPNotifier) Run(st *utils.Stopper) { | ||
| defer st.End() | ||
| // NewNotifier initializes a new Notifier from the specified configuration. | ||
| func NewNotifier(cfg Config) *Notifier { |
There was a problem hiding this comment.
You could just call this New to make it less redundant. It would look like notifier.New() then.
|
rebase |
Quentin-M
force-pushed
the
notifier_tls
branch
2 times, most recently
from
203607f to
0ec7ad5
Compare
Quentin-M
force-pushed
the
notifier_tls
branch
from
0ec7ad5 to
9946382
Compare
|
LGTM |
Quentin-M
pushed a commit
that referenced
this pull request
Dec 4, 2015
notifier: Refactor and add client certificate authentification support.
jzelinskie
added
area/usability
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #23