Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make pgsql tests database agnostic and actual unit tests #264

Closed
Quentin-M opened this issue Nov 12, 2016 · 1 comment
Closed

Make pgsql tests database agnostic and actual unit tests #264

Quentin-M opened this issue Nov 12, 2016 · 1 comment
Labels
area/testing related to improving test coverage kind/cleanup no functional changes, only reorganization kind/feature request wishes for new functionality/docs priority/medium desired functionality

Comments

@Quentin-M
Copy link
Contributor

In the early stages of the project, most of the database tests were implementation agnostic and were running on each registered implementation. But it got removed after an internal discussion for a silly reason that I can't seem to remember. We should extract the tests from the pgsql package, make them database agnostic and move them to the database package, just like before.

Also, instead of using scenario based tests, we should definitely make them unit tests and use fixtures more often.

@Quentin-M Quentin-M added area/testing related to improving test coverage component/database kind/feature request wishes for new functionality/docs labels Nov 12, 2016
@jzelinskie jzelinskie added kind/cleanup no functional changes, only reorganization lifecycle/preserve priority/medium desired functionality labels Sep 26, 2018
@hdonnay
Copy link
Member

hdonnay commented Aug 31, 2020

We’re declaring bug bankruptcy as part of the release process for a new major version of Clair. Please open a ticket in our issue tracker if you feel this still needs to be addressed, and we'll triage as part of our v4 development process. Thanks!

@hdonnay hdonnay closed this as completed Aug 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/testing related to improving test coverage kind/cleanup no functional changes, only reorganization kind/feature request wishes for new functionality/docs priority/medium desired functionality
Development

No branches or pull requests

3 participants