Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overflow:hidden lingers after closing a drawer by dragging (fix #1809) (v0.15) #1811

Closed
wants to merge 1 commit into from

Conversation

6112
Copy link

@6112 6112 commented Mar 20, 2018

See #1809 and sister PR, #1810.

Fixes a bug where closing a drawer in a certain way causes the page to become un-scrollable (on small viewports).

This fix is for v0.15, and #1810 is a fix for the v0.14 version of the bug.

What kind of change does this PR introduce? (check at least one)

  • Bugfix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

The PR fulfills these requirements:

  • It's submitted to the dev branch and not the master branch
  • When resolving a specific issue, it's referenced in the PR's title (e.g. fix: #xxx[,#xxx], where "xxx" is the issue number)
  • It's been tested with all Quasar themes
  • It's been tested on a Cordova (iOS, Android) app
  • It's been tested on a Electron app
  • Any necessary documentation has been added or updated in the docs (for faster update click on "Suggest an edit on GitHub" at bottom of page) or explained in the PR's description.

If adding a new feature, the PR's description includes:

  • A convincing reason for adding this feature (to avoid wasting your time, it's best to open a suggestion issue first and wait for approval before working on it)

Other information:

@6112 6112 changed the title fix: overflow:hidden lingers after closing a drawer by dragging fix: overflow:hidden lingers after closing a drawer by dragging (#1809) Mar 20, 2018
@6112 6112 changed the title fix: overflow:hidden lingers after closing a drawer by dragging (#1809) fix: overflow:hidden lingers after closing a drawer by dragging (fix #1809) (v0.15) Mar 20, 2018
@rstoenescu
Copy link
Member

Implemented before I saw the PR.

@rstoenescu rstoenescu closed this Mar 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants