Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drawer - Bug on Open #287

Closed
JeremyBYU opened this issue Dec 28, 2016 · 5 comments
Closed

Drawer - Bug on Open #287

JeremyBYU opened this issue Dec 28, 2016 · 5 comments

Comments

@JeremyBYU
Copy link

Hi,
Love the project! However I just wanted to share a small bug I found. When you use q-drawer and attempt to open by swiping with your thumb starting from the left and finish almost all the way to the right then the drawer does not open and the screen turns black. This is running it with the cordova wrapper, not sure if it exists just using chrome.

Attached is a GIF demonstrating this. The first swipe shows the bug, with the thumb extending almost all the way to the right. The second swipe shows it correctly where you only slide to about halfway. The final swipe shows the bug again (let the gif run through once, sometimes it choppy the first time it runs).

bug-quasar-framework

Version Numbers:

 "dependencies": {
    "babel-runtime": "^6.0.0",
    "fastclick": "^1.0.6",
    "material-design-icons": "^3.0.1",
    "moment": "^2.15.0",
    "quasar-framework": "^0.11.0",
    "roboto-fontface": "^0.6.0",
    "velocity-animate": "^1.2.3",
    "vue": "2.1.7",
    "vue-router": "^2.0.0"
  },

Also here is the relevant code:

<template>
  <q-layout>
    <div slot="header" class="toolbar">
      <button class="hide-on-drawer-visible" @click="$refs.leftDrawer.open()">
        <i>menu</i>
      </button>
      <q-toolbar-title :padding="1">
        Alexa Love Notes
      </q-toolbar-title>
    </div>
    <q-drawer ref="leftDrawer">
      <div class="toolbar light">
        <q-toolbar-title :padding="1">
            Menu
        </q-toolbar-title>
      </div>
      <div class="list no-border platform-delimiter">
        <q-drawer-link icon="help" to="/about/">
          About
        </q-drawer-link>
        <hr>
        <q-drawer-link icon="list" to="/notes/">
          My Notes
        </q-drawer-link>
      </div>
    </q-drawer>
    <router-view class="layout-view">
</template>
@rstoenescu
Copy link
Member

Will investigate. Thanks!

@rstoenescu
Copy link
Member

Confirmed. This is next on my list of fixes.

rstoenescu added a commit that referenced this issue Dec 28, 2016
@JeremyBYU
Copy link
Author

Wow that was fast! I'll give it a shot and see if it works. How should I get the fix? Pull from master?

"quasar-framework": "^0.11.0",

to

"quasar-framework": "git://github.com/quasarframework/quasar.git#master",

@rstoenescu
Copy link
Member

Easy fix :)
Instructions here for nightly build: http://quasar-framework.org/guide/quasar-nightly-build.html
Make sure you delete node_modules/quasar-framework before npm installing nightly (this needs to be added to docs).

Enjoy!

@JeremyBYU
Copy link
Author

Fixed worked perfectly! Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants