Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ios] Insufficient margin in the Drawer header. #217

Closed
xereda opened this issue Nov 19, 2016 · 8 comments
Closed

[ios] Insufficient margin in the Drawer header. #217

xereda opened this issue Nov 19, 2016 · 8 comments
Milestone

Comments

@xereda
Copy link

xereda commented Nov 19, 2016

Insufficient margin in the Drawer header.

The lack of margin at the top of the application header is resulting in a poor usability experience. When I try to access the menu, the access button (hamburger / 3 lines) gets very close to the cell status bar, which results in its inoperability most of the time. I need to keep trying to hit the button to get the sidemenu to open.

I think we should, by default, increase this distance between the Drawer Quasar header and the cell phone status bar.

To illustrate this, I took some applications as an example.

quasar app:
no_space

zocdoc:
zocdoc

google inbox (new gmail):
inbox_google

made in ionic1:
ionic1

google drive:
google_drive

These are just a few examples. All of them have a larger margin between the header and the cell bar status.

Another issue I believe affects the sensitivity of the burger button, is its size. It should be a little bigger. Close to 20% ... what do you think !?

@robmpreston
Copy link

Yes, I had to manually adjust the size of the burger button and the margin on my production apps. Was hard to trigger it, especially on my 6+.

@rstoenescu
Copy link
Member

Confirmed. Will get fixed.

@xereda
Copy link
Author

xereda commented Nov 21, 2016

@robmpreston In what class did you increase the margin?

And @rstoenescu, will you some good practice for me to do this manually!? I do not want it to impact, in the future, on the use of other components.

@xereda
Copy link
Author

xereda commented Nov 21, 2016

I'm trying to palliate this need, but it's not getting good. The header buttons and title are centered, and that's not what we need. We need only a padding to occur at the top of the header.

@rstoenescu
Copy link
Member

Just please wait for the fix. It should be easy. Didn't have time for it yet. Consider this solved. It will get into v0.9 which I'll release this week. Thanks.

@xereda
Copy link
Author

xereda commented Nov 21, 2016

Tks.

@rstoenescu rstoenescu changed the title Insufficient margin in the Drawer header. [ios] Insufficient margin in the Drawer header. Nov 23, 2016
@rstoenescu rstoenescu added this to the v0.10 milestone Dec 6, 2016
@rstoenescu rstoenescu modified the milestones: v0.11, v0.10 Dec 16, 2016
@sunnygill31
Copy link

@rstoenescu I think this is again broken with iPhone X.

@rstoenescu
Copy link
Member

@sunnygill31 iPhoneX changes a few things. The new starter kit for v0.15 takes care of the problem. Will do a final test before v0.15 is released (really soon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants