Skip to content
This repository has been archived by the owner on Dec 13, 2019. It is now read-only.

Incorrect upgrade message given when running quasar dev #196

Open
smakinson opened this issue Oct 23, 2018 · 6 comments
Open

Incorrect upgrade message given when running quasar dev #196

smakinson opened this issue Oct 23, 2018 · 6 comments

Comments

@smakinson
Copy link

Software version

NPM 6.4.0
yarn 1.10.1
quasar-cli 0.17.20
vue-cli 3.0.1
quasar-framework 0.17.17
Any other software related to your bug:

What did you get as the error?

Your newer Quasar CLI requires a minor change to /src/index.template.html
   Please remove this section completely:

   <% if (htmlWebpackPlugin.options.ctx.mode.pwa) { %>
    <!-- Add to home screen for Android and modern mobile browsers -->
    .....
   <% } %>

Those lines do not exist in index.template.html but I still see the message and cannot run quasar dev while <link rel="manifest" href="site.webmanifest"> is in index.template.html

What were you expecting?

No error.

What steps did you take, to get the error?

Added <link rel="manifest" href="site.webmanifest"> to index.template.html
@jigarzon
Copy link

jigarzon commented Feb 1, 2019 •
edited
Loading

Same happening here. This is my index.template.html:

<!DOCTYPE html>
<html>
  <head>
    <title><%= htmlWebpackPlugin.options.productName %></title>

    <meta charset="utf-8">
    <meta name="description" content="<%= htmlWebpackPlugin.options.productDescription %>">
    <meta name="format-detection" content="telephone=no">
    <meta name="msapplication-tap-highlight" content="no">
    <meta name="viewport" content="user-scalable=no, initial-scale=1, maximum-scale=1, minimum-scale=1, width=device-width">
    <link rel="apple-touch-icon" sizes="180x180" href="statics/apple-touch-icon.png">
    <link rel="icon" type="image/png" sizes="32x32" href="statics/favicon-32x32.png">
    <link rel="icon" type="image/png" sizes="16x16" href="statics/favicon-16x16.png">
    <link rel="manifest" href="statics/site.webmanifest">
    <link rel="mask-icon" href="statics/safari-pinned-tab.svg" color="#5bbad5">
    <link rel="shortcut icon" href="statics/favicon.ico">
    <meta name="msapplication-TileColor" content="#da532c">
    <meta name="msapplication-config" content="statics/browserconfig.xml">
    <meta name="theme-color" content="#ffffff">
  </head>
  <body>
    <!-- DO NOT touch the following DIV -->
    <div id="q-app"></div>
  </body>
</html>

@ddsky
Copy link

ddsky commented Feb 3, 2019

got the same

@jigarzon
Copy link

jigarzon commented Feb 4, 2019 •
edited
Loading

This is code starting at line 41 of legacy-validations.js. I would make a PR for it, but I really don't understand the purpose of that lines:

  if (content.indexOf('<link rel="manifest"') > -1) {
    console.log(`\n⚠️  Your newer Quasar CLI requires a minor change to /src/index.template.html
   Please remove this section completely:

   <% if (htmlWebpackPlugin.options.ctx.mode.pwa) { %>
    <!-- Add to home screen for Android and modern mobile browsers -->
    .....
   <% } %>
  `)
    console.log()
    error = true
  }

@jigarzon
Copy link

jigarzon commented Feb 4, 2019

So, a fix would be remove anything containing <link rel="manifest". (Or add an extra space between link and rel 🤔 )

@bretonio
Copy link

I have this difficulty as well. There were several lines listed for removal but only the one you cited keeps coming back from the dead even after I run quasar build. For the record this line is

<% if (htmlWebpackPlugin.options.ctx.mode.pwa) { %>
    <!-- Add to home screen for Android and modern mobile browsers -->
    .....
   <% } %>

I opened a fresh bash shell to run quasar in and I also rebooted.

@rstoenescu
Copy link
Member

The code that you are all referencing is no longer part of Quasar. Please upgrade to latest v1.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@smakinson @ddsky @rstoenescu @jigarzon @bretonio