Follow up tweak on Deno.removeSync issues #7988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
From last user's comment it could be a different issue |
cderv
force-pushed
the
safeRemoveSync-followup
branch
from
6d5384b to
cc88129
Compare
cderv
force-pushed
the
safeRemoveSync-followup
branch
from
cc88129 to
bd3f37a
Compare
|
I keep encountering this on windows with mediabag, so I believe this is ok to make this change now. |
cscheid
reviewed
Jun 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up on #4614 and #7921
It seems there is another place where removing the
mediabagis possibly throwing a Deno error while it works.See #4614 (comment)
Again narrow fix where the errors shared comes from. There are other occurence of
Deno.removeSyncbut I left them open