--output-dir fails on cross-device destination

[castedo]

Bug description

STEPS: from empty directory on Linux

sudo mkdir /tmp2
sudo mount -t tmpfs tmpfs /tmp2
echo Hi > test.qmd
touch _quarto.yml
quarto render test.qmd --to markdown --output-dir /tmp2

RESULT: quarto outputs:

ERROR: Invalid cross-device link (os error 18), rename '/home/castedo/shr/bugs/q2/test.md' -> '/tmp2/test.md'

NOTES:

1. This works:

quarto render test.qmd --to markdown --output-dir tmp2

2. So does

echo Hola > /tmp2/hi.txt
cat /tmp2/hi.txt

3. These steps with a tmpfs are not my actually usage scenario. I hit this because I run quarto inside a container and was outputing into a public_html directory mounted outside the container. Similar issue should get hit with VMs and shared folders.

Easy for me to work around though.

ENVIRONMENT:

[castedo@quarto-1 1]$ quarto --version
1.1.251
[castedo@quarto-1 1]$ cat /etc/os-release
NAME="Fedora Linux"
VERSION="36 (Container Image)"
ID=fedora
VERSION_ID=36
...

Checklist

• Please include a minimal, fully reproducible example in a single .qmd file? Please provide the whole file rather than the snippet you believe is causing the issue.
• Please format your issue so it is easier for us to read the bug report.
• Please document the RStudio IDE version you're running (if applicable), by providing the value displayed in the "About RStudio" main menu dialog?
• Please document the operating system you're running. If on Linux, please provide the specific distribution.

[cderv]

We should probably check --output flag also as a similar issue is reported in quarto-dev/quarto-r#35

quarto-cli/src/command/render/output-tex.ts

Line 84 in 2bdf5e8

Deno.renameSync(pdfOutput, outputPdf);

What we do in R Markdown to prevent this type of issue is having a moving function that is

• Copying and then renaming
• Deleting original files copied

Seems like that is what was adviced in Deno too : denoland/deno#3092

Maybe we should have a wrapper of Deno.RenameSync that handles this type error and do a copying instead.

[grst]

There seems to be a PR open in deno now:
denoland/deno#19879

[rcannood]

Just encountered this issue in pkgdown as well. Would it help to replace all fs.renameSync(a, b) with the following?

  try {
    fs.renameSync(a, b)
  } catch (err: unknown) {
    console.log(`Failed to rename file: ${err}`)
    fs.copyFileSync(a, b)
    fs.unlinkSync(a)
  }

[cscheid]

Not that simple when directories are involved.