Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some of the TODOs got into the final rendered HTML #11401

Closed
pawelru opened this issue Nov 14, 2024 · 4 comments · Fixed by #11436
Closed

Some of the TODOs got into the final rendered HTML #11401

pawelru opened this issue Nov 14, 2024 · 4 comments · Fixed by #11436

Comments

@pawelru
Copy link

pawelru commented Nov 14, 2024

My auto TODO detector is screaming when looking into the _site subdir:
Image

This are repeating across the subpage and it looks like it mostly coming from those two:

// TODO: Check when it could be a function (https://github.com/zenorocha/clipboard.js/issues/860)

// TODO in 1.5, we should make sure this works without a callout special case

It looks like it got injected into every single page I have. Since it's a comment it's probably not a big deal though but I thought I would share this with you.

@cscheid
Copy link
Collaborator

cscheid commented Nov 14, 2024

@pawelru
Copy link
Author

pawelru commented Nov 14, 2024

These are not my comments :) linked code snippets belong here - quarto-cli repo

@gadenbuie
Copy link
Collaborator

My auto TODO detector is screaming when looking into the _site subdir

You should configure your TODO detector to ignore the _site subdir. If you're using Todo Tree in VS Code, look for the "Filtering: Exclude Globs" setting.

@cscheid
Copy link
Collaborator

cscheid commented Nov 14, 2024

Ah, sorry. It turns out that we don't mind those TODOs there, but I'll make the change anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants