-
Notifications
You must be signed in to change notification settings - Fork 335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
highlight-style
treated differently for format: *
and format: live-*
#10717
Comments
Currently, the background colour for the Quarto Live code editor is decided by the following rules in CSS:
So the issue happens when the highlighting theme requires that code is typeset on a dark background, but the Quarto theme otherwise has a light background on the web page. This is a problem that should really be fixed in Quarto Live. The CSS for the live editor should listen to the highlighter theme in some way to provide a dark background if required. I will need to think about this a bit, I think the assumption that a "light" highlighter theme will be used with a "light" quarto theme is pretty strong in Quarto Live's CSS rules right now. |
What's unclear to me is which syntax highlighting is the light one using? It's not |
It's We're working on exporting both the correct background and base text colours in #10722 so that Quarto Live can set them correctly in the editor. For the moment a short term workaround is to avoid mixing a light Quarto theme with a dark highlighting theme (i.e setting |
This is now to follow up on #10722. In next quarto 1.6, any SCSS variable will be made available as CSS root variable with namespace We don't have yet a full extensive list of available variable, and this is quite new, but still can be used to access value set to color like code background. Should help solve this issue in quarto-live. |
Apologies for the delay but the latest commit of Quarto Live now makes use of the We should still deal with the gutter in the future, but for now at least the code should be readable in the main body of the Quarto Live editor and match more closely Quarto's own code blocks. |
Note that there's still an issue when using |
I have a website project with
revealjs
slides andhtml
files in it.I set
highlight-style: a11y-dark
at the metadata level.In both
live-revealjs
andlive-html
outputs, the non-interactive code cells use the correct highlight style:However, in the interactive (webr) code cells, a different style is applied.
Note that this doesn't happen if
highlight-style: github
, for example.cc @cderv
The text was updated successfully, but these errors were encountered: