-
Notifications
You must be signed in to change notification settings - Fork 330
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Detect Microsoft Edge install (if Google Chrome isn't) on MacOS #10162
Comments
I don't Quarto should try to detect whatever chromium-based browser is installed. This being said, having a Note that chromium is not a full browser and not the same as Chrome. Quarto needs chromium not a browser.
This being said, from the documentation:
So Edge should be detected but maybe only on Windows. |
What do you mean? |
Sorry, I meant Quarto does not use/install the full version of Chromium and that Chromium has a very minimalist user interface without all the features Chrome/Edge/Brave/etc have |
Having an environment variable would be really helpful. My issue with the |
We'll add an environment variable. Seems like a good thing to do for 1.6. |
@cscheid we probably also need to update the documentation as we currently state that both Chrome and Edge are detected by Quarto. |
I have opened an macro issue to track a proper solution for all chromium based browser
as this is not the first time this Chromium configuration question is raised |
@mcanouil We do detect Edge I believe, but on Windows only it seems quarto-cli/src/core/puppeteer.ts Lines 209 to 233 in e8c3cbf
Documentation is not completely incorrect, it is probably just innacurate by not stating it is windows only. So I believe this is the part of the code that could be fixed easily to indeed also find Edge on Mac as it is done on Windows, as it happens Edge is available on Mac and Windows. @jmhammond where Edge is located on Mac ? Same place as Google Chrome ? |
|
Ah thanks ! Missed it ! |
Bug description
When trying to render documents that include diagrams, we need to have some chrome-based browser installed.
Because of work, I have Microsoft Edge installed, and I don't have Google Chrome, because the two browsers are both really large.
The line of code here:
looks only for Chrome on MacOS, but checks for Edge when the OS is Windows. Is it possible to also look for
/Applications/Microsoft\ Edge.app/Contents/MacOS/Microsoft\ Edge
on MacOS?Steps to reproduce
Expected behavior
Detect Microsoft Edge as my chromium browser (as noted in the documentation).
Actual behavior
It says I need to install chrome.
Your environment
Quarto check output
The text was updated successfully, but these errors were encountered: