Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PID coefficients settings #657

Open
nkrackow opened this issue Dec 7, 2022 · 0 comments
Open

PID coefficients settings #657

nkrackow opened this issue Dec 7, 2022 · 0 comments
Labels
enhancement New feature or request

Comments

@nkrackow
Copy link
Contributor

nkrackow commented Dec 7, 2022

stabilizer/py/stabilizer/iir_coefficients.py

Line 185 in 57f3537

def pid_coefficients(args):

The current python tools for setting IIR coefficients make use of the function above that only takes args. There could be better options for general use without the command line tool. Maybe something similar to https://github.com/quartiq/ai-artiq-py/blob/master/aiartiq/pid.py
@jordens jordens added the enhancement New feature or request label Dec 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jordens @nkrackow