Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build cache - Include the native executable -runner in failsafe input #37433

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

gsmet
Copy link
Member

@gsmet gsmet commented Nov 30, 2023

@jprinet could you check that it makes sense?

I want to include for instance target/quarkus-integration-test-hibernate-validator-999-SNAPSHOT-runner in the failsafe run of the HV IT module.

This comment has been minimized.

Copy link
Contributor

@jprinet jprinet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a small comment

<fileSet>
<name>native-runner</name>
<paths>
<path>${project.basedir}/target</path>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that you should be able to use ${project.build.directory}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yes, stupid me, thanks!

Copy link

quarkus-bot bot commented Dec 1, 2023

✔️ The latest workflow run for the pull request has completed successfully.

It should be safe to merge provided you have a look at the other checks in the summary.

@gsmet gsmet merged commit 0c1ef3a into quarkusio:main Dec 4, 2023
49 checks passed
@quarkus-bot quarkus-bot bot added this to the 3.7 - main milestone Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants