Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support StatementInspector as @PersistenceUnitExtension managed bean #30640

Merged
merged 1 commit into from
Jan 27, 2023
Merged

Support StatementInspector as @PersistenceUnitExtension managed bean #30640

merged 1 commit into from
Jan 27, 2023

Conversation

gastaldi
Copy link
Contributor

@gastaldi gastaldi requested review from Sanne and yrodiere January 26, 2023 18:06
@quarkus-bot quarkus-bot bot added area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE labels Jan 26, 2023
@quarkus-bot
Copy link

quarkus-bot bot commented Jan 26, 2023

/cc @Sanne (hibernate-orm), @gsmet (hibernate-orm), @yrodiere (hibernate-orm)

@gastaldi gastaldi force-pushed the statement_inspector branch from fc558a0 to 07ffbb2 Compare January 26, 2023 18:15
@gastaldi gastaldi force-pushed the statement_inspector branch from 07ffbb2 to 471b8af Compare January 26, 2023 18:16
@gastaldi gastaldi force-pushed the statement_inspector branch from 471b8af to 49160ad Compare January 26, 2023 18:38
@github-actions
Copy link

github-actions bot commented Jan 26, 2023 •
edited
Loading

🙈 The PR is closed and the preview is expired.

@quarkus-bot
Copy link

quarkus-bot bot commented Jan 26, 2023

Failing Jobs - Building 49160ad

Status Name Step Failures Logs Raw logs
✔️ Gradle Tests - JDK 11
✖ Gradle Tests - JDK 11 Windows Build Failures Logs Raw logs

Full information is available in the Build summary check run.

Failures

⚙️ Gradle Tests - JDK 11 Windows #

- Failing: integration-tests/gradle

📦 integration-tests/gradle

✖ io.quarkus.gradle.devmode.DependencyConstraintsDevModeTest.main line 14 - More details - Source on GitHub

java.lang.AssertionError: 

Expecting actual:

yrodiere
yrodiere approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@yrodiere yrodiere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@yrodiere yrodiere merged commit 232980d into quarkusio:main Jan 27, 2023
@quarkus-bot quarkus-bot bot added this to the 2.17 - main milestone Jan 27, 2023
@quarkus-bot quarkus-bot bot added the kind/enhancement New feature or request label Jan 27, 2023
@gastaldi gastaldi deleted the statement_inspector branch January 27, 2023 13:25
This was referenced Feb 7, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrodiere yrodiere yrodiere approved these changes

@Sanne Sanne Awaiting requested review from Sanne

Assignees
No one assigned
Labels
area/documentation area/hibernate-orm Hibernate ORM area/persistence OBSOLETE, DO NOT USE kind/enhancement New feature or request release/noteworthy-feature triage/flaky-test
Projects
None yet
Milestone
3.0.0.Alpha4
Development

Successfully merging this pull request may close these issues.

Add support for STATEMENT_INSPECTOR in Hibernate ORM
2 participants
@gastaldi @yrodiere