Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Authenticated annotation is not supported for the reactive routes #4646

Open
sberyozkin opened this issue Oct 17, 2019 · 2 comments
Open

Authenticated annotation is not supported for the reactive routes #4646

sberyozkin opened this issue Oct 17, 2019 · 2 comments
Labels
kind/enhancement New feature or request

Comments

@sberyozkin
Copy link
Member

sberyozkin commented Oct 17, 2019

Description
@Authenticated is meant to resolve the problems similar to the one at #4544 where an access to the resource has to be denied by simply requiring that a user must've been authenticated.

Implementation ideas
Stuart @stuartwdouglas recommends that CDI interceptor has to be created to support @Authenticated on the reactive routes.
@michalszynkiewicz FYI, given that you are already working on the CDI security interceptors :-)

@sberyozkin sberyozkin added the kind/enhancement New feature or request label Oct 17, 2019
@michalszynkiewicz
Copy link
Member

michalszynkiewicz commented Oct 17, 2019

it's almost there: https://github.com/quarkusio/quarkus/pull/4413/files#diff-2e5dbf19cb91f299787caf7fac571c08R1 ;)
I think a dedicated handler to translate the exception to a proper status code would be required. But it should be easy to implement it (I already played with it but it didn't work for Resteasy on servlet so went back to exception mappers).

Should we target it in 1.0 or can it be done later? If it's for 1.0 I'll try to make it work in my current PR.

@gastaldi
Copy link
Contributor

gastaldi commented Jan 4, 2022

Is this still an issue? The referenced PRs in this issue were already merged/closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants