Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

io.quarkus.grpc.deployment is split across multiple modules #44727

Closed
dmlloyd opened this issue Nov 26, 2024 · 6 comments
Closed

io.quarkus.grpc.deployment is split across multiple modules #44727

dmlloyd opened this issue Nov 26, 2024 · 6 comments
Assignees
Labels
area/grpc gRPC area/housekeeping Issue type for generalized tasks not related to bugs or enhancements

Comments

@dmlloyd
Copy link
Member

dmlloyd commented Nov 26, 2024

The aforementioned package may be found in these modules:

  • extensions/grpc/codegen
  • extensions/grpc/deployment
Copy link

quarkus-bot bot commented Nov 26, 2024

/cc @alesj (grpc), @cescoffier (grpc)

@quarkus-bot quarkus-bot bot added the area/grpc gRPC label Nov 26, 2024
@geoand geoand added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Nov 27, 2024
@alesj
Copy link
Contributor

alesj commented Nov 27, 2024

@cescoffier I guess we could rename the one's in codegen?
No harm to that ... afais

@cescoffier
Copy link
Member

It's no problem in codegen—it should not have been used anywhere else (honestly, I don't see how it could have been used outside of our integration).

@alesj
Copy link
Contributor

alesj commented Nov 27, 2024

So ... OK to rename in codegen?
Well, it's an easy mistake to make ... to use it elsewhere, when the name is so generic and useful :-)

@cescoffier
Copy link
Member

@alesj yes, go ahead and rename the package in codegen.

@alesj
Copy link
Contributor

alesj commented Dec 17, 2024

Renamed.

@alesj alesj closed this as completed Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/grpc gRPC area/housekeeping Issue type for generalized tasks not related to bugs or enhancements
Projects
None yet
Development

No branches or pull requests

4 participants