Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generate JBang config from //Q:CONFIG #44466

Open
radcortez opened this issue Nov 13, 2024 · 1 comment
Open

Generate JBang config from //Q:CONFIG #44466

radcortez opened this issue Nov 13, 2024 · 1 comment
Assignees
Labels
area/config area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/jbang Issues related to when using jbang.dev with Quarkus

Comments

@radcortez
Copy link
Member

radcortez commented Nov 13, 2024

Description

We must propagate the JBang config set by //Q:CONFIG. To achieve this, we added a setRuntimeProperties in the QuarkusBootstrap builder. Currently, only JBang uses this API, but it is widely available for other pieces (build, tests, etc.).

While adding a setRuntimeProperties was an easy fix, it may cause issues if someone uses it outside its intended behavior (record runtime properties during build).

See:

Implementation ideas

We could eliminate the API by generating config sources for //Q:CONFIG instead and attaching them to the project.

@radcortez radcortez added the area/housekeeping Issue type for generalized tasks not related to bugs or enhancements label Nov 13, 2024
Copy link

quarkus-bot bot commented Nov 13, 2024

/cc @maxandersen (jbang), @quarkusio/devtools (jbang)

@quarkus-bot quarkus-bot bot added area/config area/jbang Issues related to when using jbang.dev with Quarkus labels Nov 13, 2024
@radcortez radcortez self-assigned this Nov 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/config area/housekeeping Issue type for generalized tasks not related to bugs or enhancements area/jbang Issues related to when using jbang.dev with Quarkus
Projects
None yet
Development

No branches or pull requests

1 participant