Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arc - BeanManager#getEvent should be adding @Default qualifier #38453

Closed
manovotn opened this issue Jan 29, 2024 · 1 comment · Fixed by #38454
Closed

Arc - BeanManager#getEvent should be adding @Default qualifier #38453

manovotn opened this issue Jan 29, 2024 · 1 comment · Fixed by #38454
Assignees
Labels
area/arc Issue related to ARC (dependency injection)
Milestone

Comments

@manovotn
Copy link
Contributor

manovotn commented Jan 29, 2024

Currently we are not adding @Default qualifier to events fired via BM#getEvent() when there is no other explicit qualifier. This seems to be against specification although there are no explicit TCKs asserting this. While this is somewhat grey area that we should revisit and clarify for the next spec version, we can definitely perform some improvements even now.
Ideally we want this behavior to be close to what BM#getInstance does WRT default qualifier.

Note that an event fired via @Inject Event<X> will have @Default added as expected.

For future reference, Weld behaves exactly the same and we are fixing that via https://issues.redhat.com/browse/WELD-2775

@manovotn manovotn added the area/arc Issue related to ARC (dependency injection) label Jan 29, 2024
@manovotn manovotn self-assigned this Jan 29, 2024
Copy link

quarkus-bot bot commented Jan 29, 2024

/cc @Ladicek (arc), @mkouba (arc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant