Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate request context activation/deactivation in grpc interceptor #38159

Closed
manovotn opened this issue Jan 12, 2024 · 1 comment · Fixed by #38195
Closed

Investigate request context activation/deactivation in grpc interceptor #38159

manovotn opened this issue Jan 12, 2024 · 1 comment · Fixed by #38195
Assignees
Labels
area/arc Issue related to ARC (dependency injection) area/grpc gRPC
Milestone

Comments

@manovotn
Copy link
Contributor

This is a follow up to #37741 where we didn't resolve the behavior in grpc.

The examples in the above issue are still valid (except the first one which was already addressed) and @michalvavrik has a branch with them over at https://github.com/michalvavrik/quarkus/tree/feature/grpc-event-observer-repro.

We should look into what's happening with req. context activation/deactivation and context state in these scenarios.
The issue seems to be with VertxCurrentContext#remove never really removing req. context which, in cases of manual context deactivation, leads to req. context permanently appearing to be active.

@manovotn manovotn added area/arc Issue related to ARC (dependency injection) area/grpc gRPC labels Jan 12, 2024
@manovotn manovotn self-assigned this Jan 12, 2024
Copy link

quarkus-bot bot commented Jan 12, 2024

/cc @alesj (grpc), @cescoffier (grpc)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/arc Issue related to ARC (dependency injection) area/grpc gRPC
Projects
None yet
1 participant